Author Topic: Enough Already!  (Read 374 times)

Robert

  • Hero Member
  • *****
  • Posts: 555
    • View Profile
Enough Already!
« on: October 17, 2020, 06:55:07 PM »
MrBCX:

Please, no more of this

Code: [Select]

  {1,"fabs"                   ,"fabs"                          ,2,comvt_BAD},
  {1,"fabsf"                  ,"fabsf"                         ,2,comvt_BAD},
  {1,"fabsl"                  ,"fabsl"                         ,2,comvt_BAD},


MrBcx

  • Administrator
  • Hero Member
  • *****
  • Posts: 714
    • View Profile
Re: Enough Already!
« Reply #1 on: October 17, 2020, 09:12:12 PM »
Robert,

Don't blame me - I didn't add any of those functions ( or iabsl for that matter )

I personally have no need for supporting them in BCX in that structure.   

Shall I remove them?

dgarner

  • Newbie
  • *
  • Posts: 33
    • View Profile
Re: Enough Already!
« Reply #2 on: October 17, 2020, 09:34:31 PM »
If you two don't think they belong, then I'd guess they don't belong.

Robert

  • Hero Member
  • *****
  • Posts: 555
    • View Profile
Re: Enough Already!
« Reply #3 on: October 17, 2020, 09:47:16 PM »
Robert,

Don't blame me - I didn't add any of those functions ( or iabsl for that matter )

I personally have no need for supporting them in BCX in that structure.   

Shall I remove them?

Hi MrBCX:

I worry about someone using those as upper case. The standard backward compatibility concern. You decide.

The IABSL implementation probably came to a dead halt when the developer looked at the syntax difference between C and C++. C++ uses overloaded ABS. I would discard that IABSL reference unless you are keen on providing that functionality.

MrBcx

  • Administrator
  • Hero Member
  • *****
  • Posts: 714
    • View Profile
Re: Enough Already!
« Reply #4 on: October 18, 2020, 06:58:19 PM »

Hi MrBCX:

I worry about someone using those as upper case. The standard backward compatibility concern. You decide.

The IABSL implementation probably came to a dead halt when the developer looked at the syntax difference between C and C++. C++ uses overloaded ABS. I would discard that IABSL reference unless you are keen on providing that functionality.

I've removed them.

Of course, they can still be used by anyone needing them.  By removing them from BCX, BCX will not detect them or transform them to lower case.  I know you know this Robert.  I'm stating this for any other readers wondering WTF this discussion is about.    ;D

"abs" will continue to transform to "fabs"
« Last Edit: October 18, 2020, 07:04:55 PM by MrBcx »